Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/288#discussion_r155824604
--- Diff:
lucene/spatial-extras/src/test/org/apache/lucene/spatial/spatial4j/Geo3dShapeRectRelationTestCase.java
---
@@ -155,16 +107,12 @@ protected Geo3dShape generateRandomShape(Point nearP)
{
ulhcPoint = lrhcPoint;
lrhcPoint = temp;
}
- final GeoBBox shape = GeoBBoxFactory.makeGeoBBox(planetModel,
ulhcPoint.getY() * DEGREES_TO_RADIANS,
- lrhcPoint.getY() * DEGREES_TO_RADIANS,
- ulhcPoint.getX() * DEGREES_TO_RADIANS,
- lrhcPoint.getX() * DEGREES_TO_RADIANS);
- return new Geo3dShape(shape, ctx);
+ return (Geo3dShape<?>) ctx.getShapeFactory().rect(lrhcPoint,
ulhcPoint);
--- End diff --
change is good but the variable names are wrong. `rect(lowerLeft,
upperRight)`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
