Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/288#discussion_r155822689
--- Diff:
lucene/spatial-extras/src/java/org/apache/lucene/spatial/spatial4j/Geo3dShapeFactory.java
---
@@ -150,10 +176,21 @@ public Rectangle rect(double minX, double maxX,
double minY, double maxY) {
@Override
public Circle circle(double x, double y, double distance) {
- GeoCircle circle = GeoCircleFactory.makeGeoCircle(planetModel,
- y * DistanceUtils.DEGREES_TO_RADIANS,
- x * DistanceUtils.DEGREES_TO_RADIANS,
- distance * DistanceUtils.DEGREES_TO_RADIANS);
+ GeoCircle circle;
+ if (planetModel.ab == planetModel.c) {
--- End diff --
Should there be a method on planetModel that more descriptively
characterizes the condition? (e.g. isSpherical?) Just a suggestion; perhaps
not if it's too hard to give an appropriate name. If not then maybe add a
comment here so we know what "ab" being equal to "c" means.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
