Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/288#discussion_r155938315
  
    --- Diff: 
lucene/spatial-extras/src/test/org/apache/lucene/spatial/spatial4j/ShapeRectRelationTestCase.java
 ---
    @@ -28,15 +28,15 @@
     
     import static 
org.locationtech.spatial4j.distance.DistanceUtils.DEGREES_TO_RADIANS;
     
    -public abstract class Geo3dShapeRectRelationTestCase extends 
RandomizedShapeTestCase {
    +public abstract class ShapeRectRelationTestCase extends 
RandomizedShapeTestCase {
       protected final static double RADIANS_PER_DEGREE = Math.PI/180.0;
     
       @Rule
       public final TestLog testLog = TestLog.instance;
     
       protected int maxRadius = 180;
     
    -  public Geo3dShapeRectRelationTestCase() {
    +  public ShapeRectRelationTestCase() {
         super(SpatialContext.GEO);
    --- End diff --
    
    I think the subclass should pass in the context.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to