[ 
https://issues.apache.org/jira/browse/LUCENE-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053826#comment-13053826
 ] 

Michael McCandless commented on LUCENE-3232:
--------------------------------------------

Patch looks great!

I wonder if we should name this module something more specific, eg docvalues?  
values?

Should we also move over ValueSource, *DocValues, FieldCacheSource?  I think, 
then, Solr 3.x grouping could cutover and then group by other field types.

> Move MutableValues to Common Module
> -----------------------------------
>
>                 Key: LUCENE-3232
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3232
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: core/search
>            Reporter: Chris Male
>             Fix For: 4.0
>
>         Attachments: LUCENE-3232.patch, LUCENE-3232.patch
>
>
> Solr makes use of the MutableValue* series of classes to improve performance 
> of grouping by FunctionQuery (I think).  As such they are used in ValueSource 
> implementations.  Consequently we need to move these classes in order to move 
> the ValueSources.
> As Yonik pointed out, these classes have use beyond just FunctionQuerys and 
> might be used by both Solr and other modules.  However I don't think they 
> belong in Lucene core, since they aren't really related to search 
> functionality.  Therefore I think we should put them into a Common module, 
> which can serve as a dependency to Solr and any module.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to