[ 
https://issues.apache.org/jira/browse/LUCENE-3232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054350#comment-13054350
 ] 

Michael McCandless commented on LUCENE-3232:
--------------------------------------------

OK this sounds like a good plan... if we can get FQs factored out soonish then 
we can simply fix grouping module to use that (ie, we don't need common module 
to hold the ValueSource, etc.).

I guess we keep the name "common" for now.  Maybe as we slurp in more stuff 
from Solr I'll like the name better :)

> Move MutableValues to Common Module
> -----------------------------------
>
>                 Key: LUCENE-3232
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3232
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: core/search
>            Reporter: Chris Male
>             Fix For: 4.0
>
>         Attachments: LUCENE-3232.patch, LUCENE-3232.patch
>
>
> Solr makes use of the MutableValue* series of classes to improve performance 
> of grouping by FunctionQuery (I think).  As such they are used in ValueSource 
> implementations.  Consequently we need to move these classes in order to move 
> the ValueSources.
> As Yonik pointed out, these classes have use beyond just FunctionQuerys and 
> might be used by both Solr and other modules.  However I don't think they 
> belong in Lucene core, since they aren't really related to search 
> functionality.  Therefore I think we should put them into a Common module, 
> which can serve as a dependency to Solr and any module.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to