[ 
https://issues.apache.org/jira/browse/SOLR-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338409#comment-16338409
 ] 

Yonik Seeley commented on SOLR-11879:
-------------------------------------

This only seems useful if we have code that reads until an exception is hit 
(i.e. uses the exception as a signaling mechanism).  Do we?
If we don't, then making this change would obscure the source of a real bug if 
it does happen.

> avoid creating a new Exception object for EOFException in FastinputStream
> -------------------------------------------------------------------------
>
>                 Key: SOLR-11879
>                 URL: https://issues.apache.org/jira/browse/SOLR-11879
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>         Environment: FastI
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>            Priority: Trivial
>         Attachments: SOLR-11879.patch
>
>
> FastInputStream creates and throws a new EOFException, every time an end of 
> stream is encountered. This is wasteful as we never use the stack trace 
> anywhere 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to