[ 
https://issues.apache.org/jira/browse/SOLR-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338708#comment-16338708
 ] 

Yonik Seeley commented on SOLR-11879:
-------------------------------------

I guess the easiest solution (without digging into the binary update protocol) 
is to simply replace the exception catch (which can obscure real issues) with
FastInputStream.peek() before the call to unmarshal() to see if there is more 
data.


> avoid creating a new Exception object for EOFException in FastinputStream
> -------------------------------------------------------------------------
>
>                 Key: SOLR-11879
>                 URL: https://issues.apache.org/jira/browse/SOLR-11879
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>         Environment: FastI
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>            Priority: Trivial
>         Attachments: SOLR-11879.patch, Screen Shot 2018-01-24 at 7.26.16 
> PM.png
>
>
> FastInputStream creates and throws a new EOFException, every time an end of 
> stream is encountered. This is wasteful as we never use the stack trace 
> anywhere 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to