[ https://issues.apache.org/jira/browse/SOLR-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345497#comment-16345497 ]
Erick Erickson commented on SOLR-11879: --------------------------------------- [~ysee...@gmail.com] There are three places in FastInputStream that I saw on a quick glance that follow this pattern, they should all get attention. This patch eliminates the most egregious one found with JFR. WDYT about creating a new JIRA to deal with all of them in a bunch? With a couple of separate commits already, this one is starting to sprawl. It might be easier to deal with in a new JIRA. > avoid creating a new Exception object for EOFException in FastinputStream > ------------------------------------------------------------------------- > > Key: SOLR-11879 > URL: https://issues.apache.org/jira/browse/SOLR-11879 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Environment: FastI > Reporter: Noble Paul > Assignee: Noble Paul > Priority: Trivial > Attachments: SOLR-11879.patch, SOLR-11879.patch, SOLR-11879.patch, > Screen Shot 2018-01-24 at 7.26.16 PM.png > > > FastInputStream creates and throws a new EOFException, every time an end of > stream is encountered. This is wasteful as we never use the stack trace > anywhere -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org