[
https://issues.apache.org/jira/browse/SOLR-11066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347521#comment-16347521
]
Shalin Shekhar Mangar commented on SOLR-11066:
----------------------------------------------
Thanks David, Gus and Andrzej!
The latest patch has the following changes:
# graceTime is renamed to graceDuration
# The trigger accepts a startTime which must be an ISO-8601 date time string
ending with the 'Z' (signalling UTC) or without 'Z'. If the date time is
without 'Z' then a time zone must be specified.
# The date math is done using the given time zone or UTC if none given
# The calculations in the trigger are all done using the Instant class
# The configuration stored in ZK is exactly what the user provided while
creating the API.
bq. It's not clear to me looking at the patch how these ScheduledTriggers are
created. Can you please explain? I was anticipating some new API call to
create the trigger.
The trigger is created using the existing set-trigger API so no API changes
were made. This is also the reason behind keeping the configuration in ZK the
same as what was given by the user. The alternative would have been for the API
to know that scheduled trigger is special and it may require modifying the
provided startTime value to UTC. The downside to the current approach is that
there is no validation of the properties until a Trigger is instantiated or
initialized.
I'm going to open another issue to add a general validation API to Trigger
which can be used for validating input configuration to avoid set-trigger calls
with bad input succeeding.
> Implement a scheduled trigger
> -----------------------------
>
> Key: SOLR-11066
> URL: https://issues.apache.org/jira/browse/SOLR-11066
> Project: Solr
> Issue Type: Sub-task
> Security Level: Public(Default Security Level. Issues are Public)
> Components: AutoScaling, SolrCloud
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: SOLR-11066.patch, SOLR-11066.patch, SOLR-11066.patch
>
>
> Implement a trigger that runs on a fixed interval say every 1 hour or every
> 24 hours starting at midnight etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
