[
https://issues.apache.org/jira/browse/LUCENE-2793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056449#comment-13056449
]
Simon Willnauer commented on LUCENE-2793:
-----------------------------------------
Varun, patch looks great!
here are some comments:
* in LuceneTestCase#newIOContext(Random) your switch statement misses necessary
break; statements no matter what you will always get a flush
context. I think you should also randominze the numbers for numDocs and
sizeInBytes. nobody should rely on these number they are just best effort.
* in o.a.l.i.values.Bytes#getValues,
o.a.l.i.StoredFieldsWriter#initFieldsWriter,
o.a.l.i.SegmentMerger#mergeVectors, MemoryCodec#fieldsProducer,
MockSingleIntIndexOutput#MockSingleIntIndexOutput you can remove the nocommit
* the public members in FlushInfo should be final
* the MergeInfo ctors javadoc should either describe the arguments or omit
them. In this case I think you can simply omit them since they are pretty self
explained. I think what we need on MergeInfo as well as on FlushInfo is a
javadoc comment that says that the values are estimates not necessarily real /
correct values.
* on private IOContext (Context context, MergeInfo mergeInfo ) I don't
understand the assert why is there a context != Flush?
* in MockDirectoryWrapper there is a nocommit that says randomize the
IOContext. Maybe we should put the newIOContext to _TestUtils and delegate to
this from LuceneTestCase?
Overall I think we are really close here. Once those comments are fixed I will
commit the patch to the branch and we go through the remaining nocommits. Once
this is done we should close this and create a new issue to fix all the buffer
sizes just like LUCENE-3248.
good job varun
> Directory createOutput and openInput should take an IOContext
> -------------------------------------------------------------
>
> Key: LUCENE-2793
> URL: https://issues.apache.org/jira/browse/LUCENE-2793
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/store
> Reporter: Michael McCandless
> Assignee: Varun Thacker
> Labels: gsoc2011, lucene-gsoc-11, mentor
> Attachments: LUCENE-2793-nrt.patch, LUCENE-2793.patch,
> LUCENE-2793.patch, LUCENE-2793.patch, LUCENE-2793.patch, LUCENE-2793.patch,
> LUCENE-2793.patch, LUCENE-2793.patch, LUCENE-2793.patch, LUCENE-2793.patch,
> LUCENE-2793.patch, LUCENE-2793.patch, LUCENE-2793.patch, LUCENE-2793.patch,
> LUCENE-2793.patch, LUCENE-2793.patch, LUCENE-2793.patch, LUCENE-2793.patch,
> LUCENE-2793.patch
>
>
> Today for merging we pass down a larger readBufferSize than for searching
> because we get better performance.
> I think we should generalize this to a class (IOContext), which would hold
> the buffer size, but then could hold other flags like DIRECT (bypass OS's
> buffer cache), SEQUENTIAL, etc.
> Then, we can make the DirectIOLinuxDirectory fully usable because we would
> only use DIRECT/SEQUENTIAL during merging.
> This will require fixing how IW pools readers, so that a reader opened for
> merging is not then used for searching, and vice/versa. Really, it's only
> all the open file handles that need to be different -- we could in theory
> share del docs, norms, etc, if that were somehow possible.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
