Uwe Schindler commented on SOLR-11795:

Hi Koji,
looks fine now. I hope Windows Jenkins is also happy (I had not enabled it on 
the branch). But the new code looks like it closes all files correctly in tests.

[~dsmiley]: The reason for the extra job was: We had a separate branch to 
improve the module, because originally there were multiple problems with it:

- Others and I complained about yet another config file format
- snakeYAML had problems on Java 9 and later (this was solved upstream, but the 
first item caused us to go away from that library) and change to conventional 
solr-like XML.
- Beasting wouldn't have helped, as it was platform-specific test failures , 
easy to reproduce. So running it in a branch before merging was a good idea. 
The main reason was also the noise currently going on on the mailing lists 
about BadApples, so it was easier to track separately.
- There was also lots of commit activity, so a branch looked like a good idea.

Personally, I often create a private branch on Github and execute it on 
Policeman Jenkins. I did this for the MR-JAR changes for longer time, just to 
test all variants of environments.

Thanks to all,

> Add Solr metrics exporter for Prometheus
> ----------------------------------------
>                 Key: SOLR-11795
>                 URL: https://issues.apache.org/jira/browse/SOLR-11795
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>    Affects Versions: 7.2
>            Reporter: Minoru Osuka
>            Assignee: Koji Sekiguchi
>            Priority: Minor
>             Fix For: master (8.0), 7.3
>         Attachments: SOLR-11795-10.patch, SOLR-11795-11.patch, 
> SOLR-11795-2.patch, SOLR-11795-3.patch, SOLR-11795-4.patch, 
> SOLR-11795-5.patch, SOLR-11795-6.patch, SOLR-11795-7.patch, 
> SOLR-11795-8.patch, SOLR-11795-9.patch, SOLR-11795-dev-tools.patch, 
> SOLR-11795.patch, solr-dashboard.png, solr-exporter-diagram.png
>          Time Spent: 20m
>  Remaining Estimate: 0h
> I 'd like to monitor Solr using Prometheus and Grafana.
> I've already created Solr metrics exporter for Prometheus. I'd like to 
> contribute to contrib directory if you don't mind.
> !solr-exporter-diagram.png|thumbnail!
> !solr-dashboard.png|thumbnail!

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to