Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/323#discussion_r172248376
  
    --- Diff: 
solr/core/src/java/org/apache/solr/schema/LatLonPointSpatialField.java ---
    @@ -71,6 +74,10 @@ protected SpatialStrategy newSpatialStrategy(String 
fieldName) {
         SchemaField schemaField = schema.getField(fieldName); // TODO change 
AbstractSpatialFieldType so we get schemaField?
         return new LatLonPointSpatialStrategy(ctx, fieldName, 
schemaField.indexed(), schemaField.hasDocValues());
       }
    +  
    +  public String geoValueToStringValue(long value) {
    --- End diff --
    
    I'd prefer you rename this to `decodeDocValueToString` and make it static, 
and add some javadocs on the result format


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to