Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/323#discussion_r172255610
--- Diff: solr/core/src/test/org/apache/solr/search/TestSolr4Spatial2.java
---
@@ -122,19 +122,19 @@ public void testRptWithGeometryGeo3dField() throws
Exception {
public void testLatLonRetrieval() throws Exception {
assertU(adoc("id", "0",
"llp_1_dv_st", "-75,41",
- "llp_1_dv", "-80,20",
- "llp_1_dv_dvasst", "10,-30"));
+ "llp_1_dv", "-80.0,20.0",
+ "llp_1_dv_dvasst", "40.299599,-74.082728"));
assertU(commit());
assertJQ(req("q","*:*", "fl","*"),
"response/docs/[0]/llp_1_dv_st=='-75,41'",
// Right now we do not support decoding point value from dv field
- "!response/docs/[0]/llp_1_dv=='-80,20'",
- "!response/docs/[0]/llp_1_dv_dvasst=='10,-30'");
+ "!response/docs/[0]/llp_1_dv=='-80.0,20.0'",
+ "response/docs/[0]/llp_1_dv_dvasst=='40.299599,-74.082728'");
assertJQ(req("q","*:*", "fl","llp_1_dv_st, llp_1_dv, llp_1_dv_dvasst"),
"response/docs/[0]/llp_1_dv_st=='-75,41'",
// Even when these fields are specified, we won't return them
--- End diff --
another obsolete comment. Don't delete it though, just say we do it by
decoding the docValue.
Since we lose some precision on decoding, can we have a test value here
that demonstrates that slight difference?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
