[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392409#comment-16392409
]
Erick Erickson commented on SOLR-7887:
--------------------------------------
This should do it. I'll commit this after 7.3 is cut absent objections. I also
created a new ReviewBoard with the new patch:
https://reviews.apache.org/r/65998/
[~ab] [~shalinmangar] I made changes to SolrSlf4jReporterTest. This was
succeeding before because the subsequent calls to addAppender in
createCoreContainer did nothing. You might want to take quick look.
The critical change is in Log4j2Watcher.java, line 251 where it now removes any
appenders of the same name as the one being added. Prior to that change, any
appenders being added with the same name were _not_ actually added. Now the
last appender for a particular name wins. This fixes the remaining test issues.
Any manual testing would be greatly appreciated as I haven't done much of that
yet, particularly the admin UI.
> Upgrade Solr to use log4j2 -- log4j 1 now officially end of life
> ----------------------------------------------------------------
>
> Key: SOLR-7887
> URL: https://issues.apache.org/jira/browse/SOLR-7887
> Project: Solr
> Issue Type: Task
> Affects Versions: 5.2.1
> Reporter: Shawn Heisey
> Assignee: Erick Erickson
> Priority: Major
> Attachments: SOLR-7887-WIP.patch, SOLR-7887-eoe-review.patch,
> SOLR-7887-eoe-review.patch, SOLR-7887.patch, SOLR-7887.patch,
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch,
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch,
> SOLR-7887.patch, SOLR-7887.patch
>
>
> The logging services project has officially announced the EOL of log4j 1:
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> In the official binary jetty deployment, we use use log4j 1.2 as our final
> logging destination, so the admin UI has a log watcher that actually uses
> log4j and java.util.logging classes. That will need to be extended to add
> log4j2. I think that might be the largest pain point to this upgrade.
> There is some crossover between log4j2 and slf4j. Figuring out exactly which
> jars need to be in the lib/ext directory will take some research.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
