[
https://issues.apache.org/jira/browse/SOLR-7887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413360#comment-16413360
]
Varun Thacker commented on SOLR-7887:
-------------------------------------
I validated two things from the Solr Admin UI
* ERRORs and WARNs getting logged correctly
* Changing log levels dynamically works correctly. Changed it a few times
thought the UI and toggled it around and the solr logs reflects it
A few comments from the patch.
1. In lucene/ivy-versions.properties we have something like this. Any reason we
can't set org.log4j.major.version = 2.11.0 and don't use the minor version
variable?
{code:java}
org.log4j.major.version = 2.11
org.log4j.minor.version = 0
org.apache.logging.log4j.version =
${org.log4j.major.version}.${org.log4j.minor.version}{code}
2. After applying the patch , the CHANGES entry has a formatting issue . The
upgrade section shouldn't contain the author names .
3. The CHANGES entry needs to reflect Log4J 2.11 instead of 2.10
4. If you grep for "log4j.properties" the new dev-tools/eclipse/run*.sh files
references them that needs to be updated. Also
solr/contrib/prometheus-exporter/bin/solr-exporter* references it.
4. Same as 4, where those files need to use -Dlog4j.configurationFile instead
of -Dlog4j.configuration . Additionally solr/bin/solr.cmd has one mention of
-Dlog4j.configuration which would need to be updated ass well.
I'm still looking at the remaining of the patch and will post my second update
in a bit
> Upgrade Solr to use log4j2 -- log4j 1 now officially end of life
> ----------------------------------------------------------------
>
> Key: SOLR-7887
> URL: https://issues.apache.org/jira/browse/SOLR-7887
> Project: Solr
> Issue Type: Task
> Affects Versions: 5.2.1
> Reporter: Shawn Heisey
> Assignee: Erick Erickson
> Priority: Major
> Fix For: 7.4
>
> Attachments: SOLR-7887-WIP.patch, SOLR-7887-eoe-review.patch,
> SOLR-7887-eoe-review.patch, SOLR-7887.patch, SOLR-7887.patch,
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch,
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch,
> SOLR-7887.patch, SOLR-7887.patch, SOLR-7887.patch
>
>
> The logging services project has officially announced the EOL of log4j 1:
> https://blogs.apache.org/foundation/entry/apache_logging_services_project_announces
> In the official binary jetty deployment, we use use log4j 1.2 as our final
> logging destination, so the admin UI has a log watcher that actually uses
> log4j and java.util.logging classes. That will need to be extended to add
> log4j2. I think that might be the largest pain point to this upgrade.
> There is some crossover between log4j2 and slf4j. Figuring out exactly which
> jars need to be in the lib/ext directory will take some research.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
