[ https://issues.apache.org/jira/browse/SOLR-12083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396833#comment-16396833 ]
Amrit Sarkar commented on SOLR-12083: ------------------------------------- If we can randomise between: {code} <updateLog> <str name="dir">${solr.ulog.dir:}</str> <str name="maxNumLogsToKeep">${solr.ulog.maxNumLogsToKeep:10}</str> <str name="numRecordsToKeep">${solr.ulog.numRecordsToKeep:100}</str> <int name="tlogDfsReplication">${solr.ulog.tlogDfsReplication:2}</int> </updateLog> {code} {code} <updateLog class="solr.CdcrUpdateLog"> <str name="dir">${solr.ulog.dir:}</str> <str name="maxNumLogsToKeep">${solr.ulog.maxNumLogsToKeep:10}</str> <str name="numRecordsToKeep">${solr.ulog.numRecordsToKeep:100}</str> <int name="tlogDfsReplication">${solr.ulog.tlogDfsReplication:2}</int> </updateLog> {code} in our solrconfig's. In-place property substitution doesn't work with XML arguments, at least I don't know how to do it. like: {code} <updateLog class=${substitute.prop}> {code} [~varunthacker]: unfortunately {{TestRealTimeGet}} doesn't fail when we have CdcrUpdateLog, but {{TestInPlaceUpdatesDistrib}} do, which essentially fails for RealTimeGetComponent. Please find the updated patch. > RealTimeGetComponent fails for INPLACE_UPDATE when Cdcr enabled > ---------------------------------------------------------------- > > Key: SOLR-12083 > URL: https://issues.apache.org/jira/browse/SOLR-12083 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: CDCR > Affects Versions: 7.2, 7.2.1, 7.3 > Reporter: Amrit Sarkar > Assignee: Varun Thacker > Priority: Major > Attachments: SOLR-12083.patch, SOLR-12083.patch > > > On the lines of SOLR-12063: Bidirectional support introduced serious bugs and > here RealTimeGetComponent is broken. > As we have added additional flag to each {{tlog}} entry, the following > assertions fail when Cdcr enabled: > {code} > if (oper == UpdateLog.UPDATE_INPLACE) { > assert entry.size() == 5; > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org