Varun Thacker commented on SOLR-12083:

Thanks Amrit for working on this!

I kind of like the SOLR-12083-A-within-test-framework.patch approach better

Couple of things about the SOLR-12083-A-within-test-framework.patch patch
 * Any reason why we don't randomzie the update log in 
TestInPlaceUpdatesDistrib like we do in the other approach?
 * Can we log in randomizeUpdateLogClsProp which update log is being used
 * A small refactor could be instead of using a sysprop and then reading the 
sysprop in SolrTestCaseJ4 to call randomizeUpdateLogClsProp , why not just make 
randomizeUpdateLogClsProp and clearUpdateLogClsProp public and call them 
directly in the beforeClass/afterClass method of TestInPlaceUpdatesDistrib / 
UpdateLogTest . What do you think?

> RealTimeGetComponent fails for INPLACE_UPDATE when Cdcr enabled 
> ----------------------------------------------------------------
>                 Key: SOLR-12083
>                 URL: https://issues.apache.org/jira/browse/SOLR-12083
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: CDCR
>    Affects Versions: 7.2, 7.2.1, 7.3
>            Reporter: Amrit Sarkar
>            Assignee: Varun Thacker
>            Priority: Major
>         Attachments: SOLR-12083-A-within-test-framework.patch, 
> SOLR-12083-B-wo-test-framework.patch, SOLR-12083.patch, SOLR-12083.patch, 
> add_support_for_random_ulog_in_tests.patch
> On the lines of SOLR-12063: Bidirectional support introduced serious bugs and 
> here RealTimeGetComponent is broken. 
> As we have added additional flag to each {{tlog}} entry, the following 
> assertions fail when Cdcr enabled:
> {code}
> if (oper == UpdateLog.UPDATE_INPLACE) {
>  assert entry.size() == 5;
> }
> {code}

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to