[
https://issues.apache.org/jira/browse/LUCENE-8205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400085#comment-16400085
]
Simon Willnauer commented on LUCENE-8205:
-----------------------------------------
yeah man I hear you! It's a massive rabbit hole which needs cleanups. I am
trying to make stuff more approachable but it's a lot of work. We are on the
same page here but it's not a low-hanging fruit. :)
> Simplify AbortingException handling and tragic event logic
> ----------------------------------------------------------
>
> Key: LUCENE-8205
> URL: https://issues.apache.org/jira/browse/LUCENE-8205
> Project: Lucene - Core
> Issue Type: Improvement
> Affects Versions: 7.4, master (8.0)
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Major
> Fix For: 7.4, master (8.0)
>
> Attachments: LUCENE-8205.patch
>
>
> Today we try to signal via exception handling if an exception is aborting
> and/or a tragic event. This causes today that we ignore certain exception if
> we
> are in the process of handling a such which is generally bad practice. This
> change simplify the signaling of aborting exceptions and separates acting on
> tragic events and closing the writer because of a tragic event. This in-turn
> simplifies lock ordering since we never acquire a lock anymore inside the
> tragic event code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
