[
https://issues.apache.org/jira/browse/LUCENE-8205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400478#comment-16400478
]
Uwe Schindler commented on LUCENE-8205:
---------------------------------------
Same for ECJ run through Ant/Jenkins:
{code:java}
[ecj-lint] 2. ERROR in C:\Users\Uwe
Schindler\Projects\lucene\trunk-lusolr1\lucene\core\src\java\org\apache\lucene\index\DocumentsWriter.java
(at line 738)
[ecj-lint] } finally {
[ecj-lint] throw t;
[ecj-lint] }
[ecj-lint] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[ecj-lint] finally block does not complete normally
{code}
> Simplify AbortingException handling and tragic event logic
> ----------------------------------------------------------
>
> Key: LUCENE-8205
> URL: https://issues.apache.org/jira/browse/LUCENE-8205
> Project: Lucene - Core
> Issue Type: Improvement
> Affects Versions: 7.4, master (8.0)
> Reporter: Simon Willnauer
> Assignee: Simon Willnauer
> Priority: Major
> Fix For: 7.4, master (8.0)
>
> Attachments: LUCENE-8205.patch, LUCENE-8205.patch,
> image-2018-03-15-15-30-16-757.png
>
>
> Today we try to signal via exception handling if an exception is aborting
> and/or a tragic event. This causes today that we ignore certain exception if
> we
> are in the process of handling a such which is generally bad practice. This
> change simplify the signaling of aborting exceptions and separates acting on
> tragic events and closing the writer because of a tragic event. This in-turn
> simplifies lock ordering since we never acquire a lock anymore inside the
> tragic event code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
