[ 
https://issues.apache.org/jira/browse/SOLR-12122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16405369#comment-16405369
 ] 

David Smiley commented on SOLR-12122:
-------------------------------------

AFAICT, in GatherNodesStream, line ~579 {{tuple.getString(traverseTo)}} can use 
getStrings(), and we loop over each value.  It appears we should also take care 
to apply the metrics logic once.  That's about it.  WDYT [~joel.bernstein]?

In Solr 7.3, multiValued docValue fields are finally sortable.  That used to be 
an obstacle.

As an aside: I'm very disappointed in the extreme lack of comments in the 
streaming expressions module.  At least I'm judging from 
{{org.apache.solr.client.solrj.io.graph}} package.  It makes code especially 
hard to read for those who didn't write it.  As a random example, Strings are 
used as keys into maps/sets but not documented what those strings are when the 
field name is non-obvious (e.g. {{List<Map<String,Node>> graph}}  -- alrighty). 
 If I end up reviewing new code going in that is similarly under-documented, 
I'll have to throw down a -1 flag.

> gatherNodes expression should support multiValued walk target
> -------------------------------------------------------------
>
>                 Key: SOLR-12122
>                 URL: https://issues.apache.org/jira/browse/SOLR-12122
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: streaming expressions
>            Reporter: David Smiley
>            Priority: Major
>
> The {{gatherNodes}} streaming expression has a {{walk}} argument that 
> articulates a pair of Solr fields of the form {{traversalFrom->traversalTo}}. 
>  It assumed that they are *not* multiValued.  It _appears_ not difficult to 
> add multiValued support to traversalTo; that's what this issue is about.
> See 
> http://lucene.472066.n3.nabble.com/Using-multi-valued-field-in-solr-cloud-Graph-Traversal-Query-td4324379.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to