[ https://issues.apache.org/jira/browse/SOLR-12134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409472#comment-16409472 ]
Steve Rowe commented on SOLR-12134: ----------------------------------- bq. let's see if the autopatch sumission review will like my patch Looks like there are a couple problems here: # The patch Yetus chose was {{nocommit.SOLR-12134.sample-failures.patch}}, rather than {{SOLR-12134.patch}}. Judging from https://yetus.apache.org/documentation/in-progress/precommit-patchnames/ I would have thought a {{nocommit.\*}} patch would be ignored. I'll ask on the Yetus mailing list about this. # The "Validate ref guide" test is reported as failed, but the log has no record of any ant target being called, so I don't know what happened. Also the comment associated with the failure refers to the wrong test ("Validate source patterns validate-source-patterns failed"). I'll run tests locally (using {{dev-tools/test-patch/test-patch.sh}}) to see if I can figure out what's happening. > validate links to javadocs in ref-guide & hook all ref-guide validation into > top level documentation/precommit > -------------------------------------------------------------------------------------------------------------- > > Key: SOLR-12134 > URL: https://issues.apache.org/jira/browse/SOLR-12134 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: documentation > Reporter: Hoss Man > Assignee: Hoss Man > Priority: Major > Attachments: SOLR-12134.patch, > nocommit.SOLR-12134.sample-failures.patch > > > We've seen a couple problems come up recently where the ref-guide had broken > links ot javadocs. > In some cases these are because people made typos in java classnames / > pathnames while editing the docs - but in other cases the problems were that > the docs were correct at one point, but then later the class was > moved/renamed/removed, or had it's access level downgraded from public to > private (after deprecation) > I've worked up a patch with some ideas to help us catch these types of > mistakes - and in general to hook the "bare-bones HTML" validation (which > does not require jekyll or any non-ivy managed external dependencies) into > {{ant precommit}} > Details to follow in comment/patch... -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org