[ 
https://issues.apache.org/jira/browse/SOLR-12134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409774#comment-16409774
 ] 

Hoss Man commented on SOLR-12134:
---------------------------------

Wild speculation w/o knowing much about Yetus...

* given that it tested the nocommit patch, it makes total sense that "Validate 
source patterns " would fail – because that patch explicitly includes the words 
"nocommit" in the modifications.
* maybe "Validate source patterns" is a configured prereq for "Validate ref 
guide" so the failure of the former ment that it didn't run the later?
** that's my uneducated  interpretation from the console output of that jenkins 
- we see it saying it's going to "Validate source patterns" on personality "." 
then we see it saying it's going to run "Validate ref guide" on personality 
"solr/solr-ref-guide" but w/o doing anything complains that "Validate source 
patterns" failed.
 
...in any case, should probably move this conversation to a Yetus specific jira?


> validate links to javadocs in ref-guide & hook all ref-guide validation into 
> top level documentation/precommit
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-12134
>                 URL: https://issues.apache.org/jira/browse/SOLR-12134
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: documentation
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>            Priority: Major
>         Attachments: SOLR-12134.patch, 
> nocommit.SOLR-12134.sample-failures.patch
>
>
> We've seen a couple problems come up recently where the ref-guide had broken 
> links ot javadocs.
> In some cases these are because people made typos in java classnames / 
> pathnames while editing the docs - but in other cases the problems were that 
> the docs were correct at one point, but then later the class was 
> moved/renamed/removed, or had it's access level downgraded from public to 
> private (after deprecation)
> I've worked up a patch with some ideas to help us catch these types of 
> mistakes - and in general to hook the "bare-bones HTML" validation (which 
> does not require jekyll or any non-ivy managed external dependencies) into 
> {{ant precommit}}
> Details to follow in comment/patch...



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to