Github user janhoy commented on the issue:
https://github.com/apache/lucene-solr/pull/342
> I wish we wouldn't have to do all those if (cores.getAuditLoggerPlugin()
!= null)
Perhaps this is better?
if (auditEnabled()) { ... }
> are you intentionally not extending any of the base test classes in your
tests
Well, yes, the tests need more work, so far they are mainly unit tests for
the raw java code. Need to add more integration tests that run real request
traffic and somehow validate that logging takes place. Guess that can be done
with a `MockAuditLogger` which can then be queried at the end of the test, or
perhaps using Mockito ?
Do you think it makes sense to randomise audit logging on one of the larger
tests such as `SolrCloudTestCase`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
