Github user tflobbe commented on the issue:
https://github.com/apache/lucene-solr/pull/342
> Perhaps this is better?
I wasn't really asking for any change, I don't like it much, but I know
that's how the related functionality is working. One option would be to create
a method like `logAudit(EventType,Request, Context...)` and do the null check
inside? IDK, just a thought.
> so far they are mainly unit tests for the raw java code
I like how simple they are. My question was in relation to things like
`reproduce with ant test -Dtests.seed=1234`, in addition to the thread leak
checking and things like that included when extending LuceneTestCase. This was
really more a question than a suggestion for change from my side.
> perhaps using Mockito
See SOLR-11606 before using Mockito
> Do you think it makes sense to randomise audit logging on one of the
larger tests such as SolrCloudTestCase?
Your call. I think the functionality is straight forward enough that
simpler tests can give you enough coverage...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
