[
https://issues.apache.org/jira/browse/SOLR-12144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16414826#comment-16414826
]
Varun Thacker commented on SOLR-12144:
--------------------------------------
SOLR_LOG_PRESTART_ROTATION also archives console logs and gc logs. So the fix
might not to remove the flag completely.
Notes from Jan on SOLR-7887 for reference
{quote}Since the current workaround is less than optimal, e.g. you need to
update numbers in {{bin/solr}} script whenever you reconfigure log4j – I think
we should start using log4j2's {{OnStartupTriggeringPolicy}} and simply delete
the whole workaround, at least the {{SolrCLI#rotateSolrLogs}}, perhaps also the
{{#removeOldSolrLogs}} since it tries to delete timestamped {{solr_log_*}}
files which were produced by an older version of Solr but not anymore.
{quote}
> Remove SOLR_LOG_PRESTART_ROTATION and leverage log4j2
> ------------------------------------------------------
>
> Key: SOLR-12144
> URL: https://issues.apache.org/jira/browse/SOLR-12144
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Varun Thacker
> Priority: Major
>
> With log4j2 rotating the file on restart is as simple as adding a policy -
> OnStartupTriggeringPolicy
> So we can remove Solr logic which does the same and exposes it via
> SOLR_LOG_PRESTART_ROTATION .
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
