[ https://issues.apache.org/jira/browse/SOLR-12144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423052#comment-16423052 ]
Jan Høydahl commented on SOLR-12144: ------------------------------------ Ok, I was not suggesting to change the actual log pattern, but to adjust the {{rotate_solr_logs}} code to work with the new pattern. Guess the reason for {{solr.N.log}} being default in log4j2 is for better file type recognition. Anyway, if log file naming is same as before we don't need a change in this patch. I'll commit soon. > Remove SOLR_LOG_PRESTART_ROTATION and leverage log4j2 > ------------------------------------------------------ > > Key: SOLR-12144 > URL: https://issues.apache.org/jira/browse/SOLR-12144 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: scripts and tools > Reporter: Varun Thacker > Assignee: Jan Høydahl > Priority: Major > Fix For: 7.4, master (8.0) > > Attachments: SOLR-12144.patch, SOLR-12144.patch > > > With log4j2 rotating the file on restart is as simple as adding a policy - > OnStartupTriggeringPolicy > So we can remove Solr logic which does the same and exposes it via > SOLR_LOG_PRESTART_ROTATION . > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org