Tapan Vaishnav commented on SOLR-11913:

Thanks for the updated patch.
{quote}Added more Javadocs, not just to the new methods here
Thanks for the Javadocs, I'll keep in mind about the manner from next time 
{quote}added a convenience method: public Stream<Map.Entry<String, String[]>> 
We are not using the _Override_  annotation for the stream function, so isn't 
it better to re-order it about the iterator function for better code style?

Thank you for all your feedbacks, there were really helpful. 

> SolrParams ought to implement Iterable<Map.Entry<String,String[]>>
> ------------------------------------------------------------------
>                 Key: SOLR-11913
>                 URL: https://issues.apache.org/jira/browse/SOLR-11913
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>              Labels: newdev
>             Fix For: 7.4
>         Attachments: SOLR-11913.patch, SOLR-11913.patch, SOLR-11913.patch, 
> SOLR-11913.patch, SOLR-11913_v2.patch
> SolrJ ought to implement {{Iterable<Map.Entry<String,String[]>>}} so that 
> it's easier to iterate on it, either using Java 5 for-each style, or Java 8 
> streams.  The implementation on ModifiableSolrParams can delegate through to 
> the underlying LinkedHashMap entry set.  The default impl can produce a 
> Map.Entry with a getValue that calls through to getParams.  

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to