[
https://issues.apache.org/jira/browse/SOLR-11913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436722#comment-16436722
]
David Smiley commented on SOLR-11913:
-------------------------------------
{quote}We are not using the _Override_ annotation for the stream function, so
isn't it better to re-order it about the iterator function for better code
style?
{quote}
Sure; I'll re-order that. There is no real code rule about that here; I just
try to maintain some semblance of some sort of organization that feels
reasonable and not haphazard.
Thanks for helping out. I'll expect to commit soon after the tests pass.
> SolrParams ought to implement Iterable<Map.Entry<String,String[]>>
> ------------------------------------------------------------------
>
> Key: SOLR-11913
> URL: https://issues.apache.org/jira/browse/SOLR-11913
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Labels: newdev
> Fix For: 7.4
>
> Attachments: SOLR-11913.patch, SOLR-11913.patch, SOLR-11913.patch,
> SOLR-11913.patch, SOLR-11913_v2.patch
>
>
> SolrJ ought to implement {{Iterable<Map.Entry<String,String[]>>}} so that
> it's easier to iterate on it, either using Java 5 for-each style, or Java 8
> streams. The implementation on ModifiableSolrParams can delegate through to
> the underlying LinkedHashMap entry set. The default impl can produce a
> Map.Entry with a getValue that calls through to getParams.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
