[
https://issues.apache.org/jira/browse/LUCENE-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438587#comment-16438587
]
Lucene/Solr QA commented on LUCENE-8248:
----------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 5s{color}
| {color:red} LUCENE-8248 does not apply to master. Rebase required? Wrong
Branch? See
https://wiki.apache.org/lucene-java/HowToContribute#Contributing_your_work for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | LUCENE-8248 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12918993/LUCENE-8248.patch |
| Console output |
https://builds.apache.org/job/PreCommit-LUCENE-Build/12/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> Rename MergePolicyWrapper to FilterMergePolicy and override all of MergePolicy
> ------------------------------------------------------------------------------
>
> Key: LUCENE-8248
> URL: https://issues.apache.org/jira/browse/LUCENE-8248
> Project: Lucene - Core
> Issue Type: Wish
> Components: core/index
> Reporter: Mike Sokolov
> Priority: Minor
> Fix For: 7.4, master (8.0)
>
> Attachments: LUCENE-8248.1.patch, LUCENE-8248.2.patch,
> LUCENE-8248.patch, LUCENE-8248.patch, MergePolicy.patch
>
>
> MergePolicy.getMaxCFSSegmentSizeMB is final, but the corresponding setter is
> not, which means that overriding it with anything other than a trivial
> delegation can only lead to confusion.
> The patch makes the method final and removes the trivial implementations from
> MergePolicyWrapper and NoMergePolicy.
> [~mikemccand] also pointed out that the class name is nonstandard for similar
> adapter classes in Lucene, which are usually Filter*.java. Personally I was
> looking for MergePolicyAdapter, but if there is a prevailing convention here
> around Filter, does it make sense to change this class's name to
> FilterMergePolicy?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
