[ 
https://issues.apache.org/jira/browse/SOLR-12045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445364#comment-16445364
 ] 

Shawn Heisey commented on SOLR-12045:
-------------------------------------

bq. The solution to class loader problems is not to move everything into a big 
fat core

In truth, I don't really care where analytics lives.  Moving it would fix the 
classloader issue, but fixing the visibility issues is probably the best idea.  
An alternate (but similar) idea would be to install the jar into the webapp 
instead of putting it in contrib.

I've cooked up a patch that changes all of the fields in ResponseBuilder to 
private and adds getters/setters as appropriate.  A lot of getters/setters were 
already in the class, so this is not a major paradigm shift.  The patch touches 
a lot of code.  I will attach it momentarily.  I'll leave the decision about 
whether to take that approach to the ones who understand the ramifications 
better than I do.

> Move Analytics Component from contrib to core
> ---------------------------------------------
>
>                 Key: SOLR-12045
>                 URL: https://issues.apache.org/jira/browse/SOLR-12045
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: master (8.0)
>            Reporter: Houston Putman
>            Priority: Major
>             Fix For: master (8.0)
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The Analytics Component currently lives in contrib. Since it includes no 
> external dependencies, there is no harm in moving it into core solr.
> The analytics component would be included as a default search component and 
> the analytics handler (currently only used for analytics shard requests, 
> might be transitioned to handle user requests in the future) would be 
> included as an implicit handler.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to