[
https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458295#comment-16458295
]
Mark Miller commented on SOLR-12290:
------------------------------------
bq. Admittedly there isn't a test for this and I forget precisely why it
mattered.
It's because we can't control closing the outputstream in some 3rd party code.
For example Jetty incorrectly does this when you forward.
We need to shield everywhere, there is no legitimate closing except by the
container, so this fixes that issue correctly by only triggering an assert when
it's our code and ignoring all non container closes all the time in non test
code.
> Improve our servlet stream closing prevention code for users and devs.
> ----------------------------------------------------------------------
>
> Key: SOLR-12290
> URL: https://issues.apache.org/jira/browse/SOLR-12290
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Mark Miller
> Assignee: Mark Miller
> Priority: Minor
> Attachments: SOLR-12290.patch, SOLR-12290.patch, SOLR-12290.patch,
> SOLR-12290.patch
>
>
> Original Summary:
> When you fetch a file for replication we close the request output stream
> after writing the file which ruins the connection for reuse.
> We can't close response output streams, we need to reuse these connections.
> If we do, clients are hit will connection problems when they try and reuse
> the connection from their pool.
> New Summary:
> At some point the above was addressed during refactoring. We should remove
> these neutered closes and review our close shield code.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
