[ 
https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458299#comment-16458299
 ] 

Mark Miller commented on SOLR-12290:
------------------------------------

bq. Jetty incorrectly

To clarify that, a Jetty servlet does it, not the Jetty container. I guess from 
that perspective it's not totally incorrect because you could say the servlet 
simply doesn't support connection reuse well. But connection reuse is very, 
very important for us and we actually plug that servlet logic into our filter. 
So we shield that servlet close, that just happens to be a jetty implemented 
servlet, and we allow only the container itself to close streams.


> Improve our servlet stream closing prevention code for users and devs.
> ----------------------------------------------------------------------
>
>                 Key: SOLR-12290
>                 URL: https://issues.apache.org/jira/browse/SOLR-12290
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>         Attachments: SOLR-12290.patch, SOLR-12290.patch, SOLR-12290.patch, 
> SOLR-12290.patch
>
>
> Original Summary:
> When you fetch a file for replication we close the request output stream 
> after writing the file which ruins the connection for reuse.
> We can't close response output streams, we need to reuse these connections. 
> If we do, clients are hit will connection problems when they try and reuse 
> the connection from their pool.
> New Summary:
> At some point the above was addressed during refactoring. We should remove 
> these neutered closes and review our close shield code.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to