[
https://issues.apache.org/jira/browse/LUCENE-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460006#comment-16460006
]
Erick Erickson commented on LUCENE-7788:
----------------------------------------
[~cpoerschke] As you've probably seen, I've been agitating for a thorough
review of our usage of logging. I think some of us will be making some active
progress along these lines, then be able to fail the precommit.
So I have several questions:
1> WDYT about failing all logging messages that aren't parameterised? Is there
any reason _any_ logging message should not be parameterised?
2> Let's say we fix up one directory (solr/core for example). Can we turn on
the precommit check on a per-directory basis?
3> Since we're going through the review in the first place we can regularize
the names of the loggers to whatever we want. It looks like "log" is the least
number of changes so it wins by default. WDYT about adding a precommit check
for that too?
> fail precommit on unparameterised log.trace messages
> ----------------------------------------------------
>
> Key: LUCENE-7788
> URL: https://issues.apache.org/jira/browse/LUCENE-7788
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: LUCENE-7788.patch, LUCENE-7788.patch
>
>
> SOLR-10415 would be removing existing unparameterised log.trace messages use
> and once that is in place then this ticket's one-line change would be for
> 'ant precommit' to reject any future unparameterised log.trace message use.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
