[
https://issues.apache.org/jira/browse/LUCENE-7960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465199#comment-16465199
]
Shawn Heisey commented on LUCENE-7960:
--------------------------------------
OK, so we re-engineer to only add a preserveOriginal parameter. That parameter
will keep original term when it is outside the min/max range.
For addressing the traps: Is that just removing the no-arg constructor,
changing the default min/max, both, or was there something else you had in mind?
In master, what constructors do you think should be there? My bias is to only
have one, but I don't live and breathe Lucene code like you do, so I trust your
judgement more than mine.
> NGram filters -- preserve the original token when it is outside the min/max
> size range
> --------------------------------------------------------------------------------------
>
> Key: LUCENE-7960
> URL: https://issues.apache.org/jira/browse/LUCENE-7960
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Reporter: Shawn Heisey
> Priority: Major
> Attachments: LUCENE-7960.patch, LUCENE-7960.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When ngram or edgengram filters are used, any terms that are shorter than the
> minGramSize are completely removed from the token stream.
> This is probably 100% what was intended, but I've seen it cause a lot of
> problems for users. I am not suggesting that the default behavior be
> changed. That would be far too disruptive to the existing user base.
> I do think there should be a new boolean option, with a name like
> keepShortTerms, that defaults to false, to allow the short terms to be
> preserved.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
