[ 
https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493646#comment-16493646
 ] 

Michael McCandless commented on LUCENE-8335:
--------------------------------------------

[~rcmuir] do you have a use case in mind where a user would actually need to 
change their soft deletes field?  I.e. are you worried that we are preventing 
such use cases?  I can't think of one.

I think adding this protection (catching users who think they can safely change 
their soft deletes field) is a natural continuation of steps we've already 
taken to make it first class feature, e.g. adding 
{{IndexWriterConfig.softDeletesField}}?

And it's dangerous now if a user writes to an index with different soft deletes 
fields in different sessions, where the second session won't detect soft 
deletes done in the first sessions.  E.g. you can't do the same thing with hard 
deletes – there is only one set of hard deletes and you can't change that from 
one IW session to another.
{quote}[~mikemccand] indicated he want's to use it
{quote}
+1 – we want to use soft deletes to track recently deleted documents that we 
can't really delete until the "out of order updates window" closes.  Today we 
are doing this by indexing explicit tombstone documents, and I suspect soft 
deletes will be cleaner.

> Do not allow changing soft-deletes field
> ----------------------------------------
>
>                 Key: LUCENE-8335
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8335
>             Project: Lucene - Core
>          Issue Type: Improvement
>    Affects Versions: 7.4, master (8.0)
>            Reporter: Nhat Nguyen
>            Assignee: Simon Willnauer
>            Priority: Minor
>         Attachments: LUCENE-8335.patch
>
>
> Today we do not enforce an index to use a single soft-deletes field. A user 
> can create an index with one soft-deletes field then open an IW with another 
> field or add an index with a different soft-deletes field. This should not be 
> allowed and reported the error to users as soon as possible.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to