[
https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497723#comment-16497723
]
Simon Willnauer commented on LUCENE-8335:
-----------------------------------------
[~dnhatn] I think your patch looks good, here are a couple of comments.
* can we make the hashmap a string and check if it's equal or null. I don't
think we should have anything mutable here and we won't allow more than one
field, right?
* should we also fail if you open a writer that has no soft-deletes field
configured but there is a field in the field infos that has the flag set?
* I also think we should fail if the field already exists and is not a
soft_deletes field but then get's marked as such. Like you can only have a
soft_deletes field if you mark it as such from the very beginning ie. as soon
as you introduce it.
> Do not allow changing soft-deletes field
> ----------------------------------------
>
> Key: LUCENE-8335
> URL: https://issues.apache.org/jira/browse/LUCENE-8335
> Project: Lucene - Core
> Issue Type: Improvement
> Affects Versions: 7.4, master (8.0)
> Reporter: Nhat Nguyen
> Assignee: Simon Willnauer
> Priority: Minor
> Attachments: LUCENE-8335.patch
>
>
> Today we do not enforce an index to use a single soft-deletes field. A user
> can create an index with one soft-deletes field then open an IW with another
> field or add an index with a different soft-deletes field. This should not be
> allowed and reported the error to users as soon as possible.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
