Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/395#discussion_r193217572
  
    --- Diff: solr/core/src/java/org/apache/solr/handler/loader/JsonLoader.java 
---
    @@ -556,82 +556,105 @@ private void parseFieldValue(SolrInputField sif) 
throws IOException {
           if (ev == JSONParser.OBJECT_START) {
             parseExtendedFieldValue(sif, ev);
           } else {
    -        Object val = parseNormalFieldValue(ev, sif.getName());
    +        Object val = parseNormalFieldValue(ev, sif);
             sif.setValue(val);
           }
         }
     
    +    private Map<String, Object> generateExtendedValueMap(int ev) throws 
IOException {
    +      assert ev == JSONParser.OBJECT_START;
    +      Map<String, Object> extendedInfo = new HashMap<>();
    +
    +      for(; ; ) {
    +        ev = parser.nextEvent();
    +        if (ev == JSONParser.OBJECT_END) {
    +          return extendedInfo;
    +        }
    +        String label = parser.getString();
    +        SolrInputField sif = new SolrInputField(label);
    +        parseFieldValue(sif);
    +        extendedInfo.put(label, sif.getValue());
    +      }
    +    }
    +
    +    private boolean isChildDoc(Map<String, Object> extendedMap) {
    +      if (extendedMap.containsKey("value") && 
extendedMap.containsKey("boost")) {
    --- End diff --
    
    lets instead simply check for the uniqueKey label


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to