Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/395#discussion_r193783399 --- Diff: solr/core/src/java/org/apache/solr/handler/loader/JsonLoader.java --- @@ -249,14 +251,27 @@ public void handle(Map<String, Object> record, String path) { private SolrInputDocument buildDoc(Map<String, Object> m) { SolrInputDocument result = new SolrInputDocument(); for (Map.Entry<String, Object> e : m.entrySet()) { - if (e.getKey() == null) {// special case. JsonRecordReader emits child docs with null key + if (entryIsChildDoc(e.getValue())) {// special case. JsonRecordReader emits child docs with null key --- End diff -- the comment is concerning; we don't want JsonRecordReader to do that anymore?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org