Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/395#discussion_r195082392
--- Diff: solr/core/src/java/org/apache/solr/handler/loader/JsonLoader.java
---
@@ -703,6 +703,10 @@ private SolrInputDocument generateExtendedValueDoc(int
ev) throws IOException {
String label = parser.getString();
SolrInputField sif = new SolrInputField(label);
parseFieldValue(sif);
+ // pulling out the pieces may seem weird, but it's because
--- End diff --
Good. The duplication of comment now has me wondering about this method
overall -- why does it seem to be duplicating existing logic -- buildDoc?
Would things "just work" if we replaced generateExtendedValueDoc with
buildDoc()? I think it would? Less look-a-like code to maintain. I suppose
the only problem with that is it would permit weird things like anonymous child
docs on a labelled child doc. I just wouldn't worry about that now though; we
catch that later in AddUpdateCommand.flatten().
BTW I'm sure you realize now that I don't have everything figured out from
the start; it's an iterative journey for you and me/the-reviewer. :-)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
