[ 
https://issues.apache.org/jira/browse/SOLR-12008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515124#comment-16515124
 ] 

Erick Erickson commented on SOLR-12008:
---------------------------------------

Here's what I have so far. I haven't tested anything yet.

There is only ./.server/resources/log4j2.xml, I've removed all the other log4j 
configs and reworked what I had time for this morning to use it.

The only place that I haven't modified is the scripts in:
./solr/server/scripts/cloud-scripts
that mention log4j. I haven't put much effort at all in to these so they may 
also be trivial. But if anyone has a minute to look who knows them better  
before I get to them that'd help. Otherwise I'll look Real Soon Now.

And anyone who wants to just try the installation script or the reworked 
Windows solr.cmd commands please feel free. There were a lot of places in 
solr.cmd that use the log4j in cloudscripts, does anyone know whether using the 
one remaining is a problem there? I'll assume it was an arbitrary choice unless 
I hear otherwise.

I also looked through the ref guide and we really don't reference the entire 
location of where that file is so I don't think there's anything to be done 
there.



> Settle a location for the "correct" log4j2.xml file.
> ----------------------------------------------------
>
>                 Key: SOLR-12008
>                 URL: https://issues.apache.org/jira/browse/SOLR-12008
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: logging
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Major
>         Attachments: SOLR-12008.patch
>
>
> As part of SOLR-11934 I started looking at log4j.properties files. Waaay back 
> in 2015, the %C in "/solr/server/resources/log4j.properties" was changed to 
> use %c, but the file in "solr/example/resources/log4j.properties" was not 
> changed. That got me to looking around and there are a bunch of 
> log4j.properties files:
> ./solr/core/src/test-files/log4j.properties
> ./solr/example/resources/log4j.properties
> ./solr/solrj/src/test-files/log4j.properties
> ./solr/server/resources/log4j.properties
> ./solr/server/scripts/cloud-scripts/log4j.properties
> ./solr/contrib/dataimporthandler/src/test-files/log4j.properties
> ./solr/contrib/clustering/src/test-files/log4j.properties
> ./solr/contrib/ltr/src/test-files/log4j.properties
> ./solr/test-framework/src/test-files/log4j.properties
> Why do we have so many? After the log4j2 ticket gets checked in (SOLR-7887) I 
> propose the logging configuration files get consolidated. The question is 
> "how far"? 
> I at least want to get rid of the one in solr/example, users should use the 
> one in server/resources. Having to maintain these two separately is asking 
> for trouble.
> [[email protected]] Do you have any wisdom on the properties file in 
> server/scripts/cloud-scripts?
> Anyone else who has a clue about why the other properties files were created, 
> especially the ones in contrib?
> And what about all the ones in various test-files directories? People didn't 
> create them for no reason, and I don't want to rediscover that it's a real 
> pain to try to re-use the one in server/resources for instance.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to