[
https://issues.apache.org/jira/browse/LUCENE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527605#comment-16527605
]
Robert Muir commented on LUCENE-8361:
-------------------------------------
Strongly disagree with making our tests wimpy because of these buggy filters.
These filters have the ability to be correct or incorrect, the problem is that
they choose to default to incorrect behavior.
They should default to correct instead, and the ctor with the boolean option
should be blacklisted in the test (since its known to be buggy).
They will still achieve their purpose, but yeah it means the user should pay
more attention to where they sit in the analysis chain and so on, that's all.
> Make TestRandomChains check that filters preserve positions
> -----------------------------------------------------------
>
> Key: LUCENE-8361
> URL: https://issues.apache.org/jira/browse/LUCENE-8361
> Project: Lucene - Core
> Issue Type: Test
> Reporter: Adrien Grand
> Assignee: Alan Woodward
> Priority: Minor
> Attachments: LUCENE-8361.patch
>
>
> Follow-up of LUCENE-8360: it is a bit disappointing that we only found this
> issue because of a newly introduced token filter. I'm wondering that we might
> be able to make TestRandomChains detect more bugs by verifying that the sum
> of position increments is preserved through the whole analysis chain.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
