[ 
https://issues.apache.org/jira/browse/LUCENE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16527636#comment-16527636
 ] 

Robert Muir commented on LUCENE-8361:
-------------------------------------

Even if we fix the default ctor to behave as correct=true, I think these 
filters will still have problems because they don't do anything with position 
increments? So they can easily stop at the wrong place (eg middle of a graph), 
cause wrong posLengths, etc.

> Make TestRandomChains check that filters preserve positions
> -----------------------------------------------------------
>
>                 Key: LUCENE-8361
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8361
>             Project: Lucene - Core
>          Issue Type: Test
>            Reporter: Adrien Grand
>            Assignee: Alan Woodward
>            Priority: Minor
>         Attachments: LUCENE-8361.patch
>
>
> Follow-up of LUCENE-8360: it is a bit disappointing that we only found this 
> issue because of a newly introduced token filter. I'm wondering that we might 
> be able to make TestRandomChains detect more bugs by verifying that the sum 
> of position increments is preserved through the whole analysis chain.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to