[
https://issues.apache.org/jira/browse/SOLR-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536709#comment-16536709
]
Cao Manh Dat edited comment on SOLR-12297 at 7/9/18 9:00 AM:
-------------------------------------------------------------
Hi, I skimmed through
https://github.com/markrmiller/starburst/commit/f1134ee6581ffd11aea6c1413d0f4375aa8406d9.patch
(the patch is huge). A large part of the patch is replacing HttpSolrClient by
Http2SolrClient which I think can be postponed. Because
* HttpSolrClient and Http2SolrClient will coexist, by replacing it we can't
sure that HttpSolrClient will work after future changes
* It makes the patch really large and hard to review.
Therefore, in my opinion, for this issue, we should focus on
* Http2SolrClient.java and some minimal tests.
* JettySolrRunner support booting up a server that accepts http2 connection
was (Author: caomanhdat):
Hi, I skimmed through
https://github.com/markrmiller/starburst/commit/f1134ee6581ffd11aea6c1413d0f4375aa8406d9.patch
(the patch is huge). A large part of the patch is replacing HttpSolrClient by
Http2SolrClient which I think can be postponed. Because
* HttpSolrClient and Http2SolrClient will coexist, by replacing them we can't
sure that HttpSolrClient will work after future changes
* It makes the patch really large and hard to review.
Therefore, in my opinion, we should focus on
* Http2SolrClient.java and some minimal tests.
* JettySolrRunner support booting up a server that accept http2 connection
> Add Http2SolrClient, capable of HTTP/1.1, HTTP/2, and asynchronous requests.
> ----------------------------------------------------------------------------
>
> Key: SOLR-12297
> URL: https://issues.apache.org/jira/browse/SOLR-12297
> Project: Solr
> Issue Type: New Feature
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Mark Miller
> Assignee: Mark Miller
> Priority: Major
> Attachments: starburst-ivy-fixes.patch
>
>
> Blocking or async support as well as HTTP2 compatible with multiplexing.
> Once it supports enough and is stable, replace internal usage, allowing
> async, and eventually move to HTTP2 connector and allow multiplexing. Could
> support HTTP1.1 and HTTP2 on different ports depending on state of the world
> then.
> The goal of the client itself is to work against HTTP1.1 or HTTP2 with
> minimal or no code path differences and the same for async requests (should
> initially work for both 1.1 and 2 and share majority of code).
> The client should also be able to replace HttpSolrClient and plug into the
> other clients the same way.
> I doubt it would make sense to keep ConcurrentUpdateSolrClient eventually
> though.
> I evaluated some clients and while there are a few options, I went with
> Jetty's HttpClient. It's more mature than Apache HttpClient's support (in 5
> beta) and we would have to update to a new API for Apache HttpClient anyway.
> Meanwhile, the Jetty guys have been very supportive of helping Solr with any
> issues and I like having the client and server from the same project.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
