[
https://issues.apache.org/jira/browse/SOLR-12555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552259#comment-16552259
]
Bar Rotstein commented on SOLR-12555:
-------------------------------------
Status report:
solr/core/src/test/org/apache/solr/cloud
• ./solr/core/src/test/org/apache/solr/cloud/ForceLeaderTest.java -> Done
• ./solr/core/src/test/org/apache/solr/cloud/OverseerStatusTest.java ->
Done
•
./solr/core/src/test/org/apache/solr/cloud/TestAuthenticationFramework.java ->
Done
•
./solr/core/src/test/org/apache/solr/cloud/TestDownShardTolerantSearch.java ->
Done
• ./solr/core/src/test/org/apache/solr/cloud/BasicZkTest.java -> Done
•
./solr/core/src/test/org/apache/solr/cloud/TestPullReplicaErrorHandling.java ->
Done
• ./solr/core/src/test/org/apache/solr/cloud/BasicDistributedZkTest.java
-> Done
• ./solr/core/src/test/org/apache/solr/cloud/DistributedQueueTest.java
-> Done
•
./solr/core/src/test/org/apache/solr/cloud/TestTolerantUpdateProcessorCloud.java
-> Done
•
./solr/core/src/test/org/apache/solr/cloud/TestSolrCloudWithSecureImpersonation.java
-> Done
• ./solr/core/src/test/org/apache/solr/cloud/DeleteReplicaTest.java ->
Done
• ./solr/core/src/test/org/apache/solr/cloud/SolrXmlInZkTest.java -> Done
• ./solr/core/src/test/org/apache/solr/cloud/TestZkChroot.java -> Done
• ./solr/core/src/test/org/apache/solr/cloud/TestConfigSetsAPI.java ->
Done
• ./solr/core/src/test/org/apache/solr/cloud/ZkCLITest.java -> Done
•
./solr/core/src/test/org/apache/solr/cloud/LeaderFailureAfterFreshStartTest.java
-> Done(None)
•
./solr/core/src/test/org/apache/solr/cloud/TestLeaderInitiatedRecoveryThread.java
-> Done
•
./solr/core/src/test/org/apache/solr/cloud/TestSolrCloudWithDelegationTokens.java
-> Done
• ./solr/core/src/test/org/apache/solr/cloud/TestCloudInspectUtil.java
-> Done
•
./solr/core/src/test/org/apache/solr/cloud/TestConfigSetsAPIZkFailure.java ->
Done
• ./solr/core/src/test/org/apache/solr/cloud/ZkSolrClientTest.java ->
Done
• ./solr/core/src/test/org/apache/solr/cloud/TestCloudDeleteByQuery.java
-> Done
•
./solr/core/src/test/org/apache/solr/cloud/CollectionsAPISolrJTest.java -> Done
•
./solr/core/src/test/org/apache/solr/cloud/BasicDistributedZk2Test.java > Done
solr/core/src/test/org/apache/solr
• solr/core/src/test/org/apache/solr/BasicFunctionalityTest.java -> Done
• solr/core/src/test/org/apache/solr/TestCursorMarkWithoutUniqueKey.java
-> Done
• solr/core/src/test/org/apache/solr/BasicFunctionalityTest.java -> Done
• solr/core/src/test/org/apache/solr/TestDistributedSearch.java -> Done
• solr/core/src/test/org/apache/solr/TestTolerantSearch.java -> Done
I have just pushed a commit and opened a pull request.
> Replace try-fail-catch test patterns
> ------------------------------------
>
> Key: SOLR-12555
> URL: https://issues.apache.org/jira/browse/SOLR-12555
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Tests
> Affects Versions: master (8.0)
> Reporter: Jason Gerlowski
> Assignee: Jason Gerlowski
> Priority: Trivial
> Attachments: SOLR-12555-sorted-by-package.txt, SOLR-12555.txt
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I recently added some test code through SOLR-12427 which used the following
> test anti-pattern:
> {code}
> try {
> actionExpectedToThrowException();
> fail("I expected this to throw an exception, but it didn't");
> catch (Exception e) {
> assertOnThrownException(e);
> }
> {code}
> Hoss (rightfully) objected that this should instead be written using the
> formulation below, which is clearer and more concise.
> {code}
> SolrException e = expectThrows(() -> {...});
> {code}
> We should remove many of these older formulations where it makes sense. Many
> of them were written before {{expectThrows}} was introduced, and having the
> old style assertions around makes it easier for them to continue creeping in.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
