[ 
https://issues.apache.org/jira/browse/SOLR-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13066268#comment-13066268
 ] 

Hoss Man commented on SOLR-2588:
--------------------------------

-1

I re-iterate...

bq. either [velocity is] a core feature and dependency, or it's an optional 
contrib.

we should not claim it is a core feature, but then silently succeed even if 
it's not found at runtime.  That will only lead to confusion for users/plugin 
devs who see that it works by default in (w/o any special <lib/> 
loading/config) in their solr instance, and then in other instances it's just 
not there w/o any warning/error on startup.

if it's a core feature then it's a core feature that people should be able to 
rely on always working with *any* solr instance (war or otherwise) and we 
should fail hard and fast if it's not found. 

if there is going to any ambiguity or about whether it is/isn't available then 
it must be rolled back to a contrib and people who want it should explicitly 
say "i want this" using a <lib/> declaration.

> Make Velocity an optional dependency in SolrCore
> ------------------------------------------------
>
>                 Key: SOLR-2588
>                 URL: https://issues.apache.org/jira/browse/SOLR-2588
>             Project: Solr
>          Issue Type: Wish
>    Affects Versions: 3.2
>            Reporter: Gunnar Wagenknecht
>            Assignee: David Smiley
>            Priority: Minor
>             Fix For: 3.4, 4.0
>
>         Attachments: SOLR-2588_Don_t_fail_if_velocity_libs_not_present_.patch
>
>
> In 1.4. it was fine to run Solr without Velocity on the classpath. However, 
> in 3.2. SolrCore won't load because of a hard reference to the Velocity 
> response writer in a static initializer.
> {noformat}
> ... ERROR org.apache.solr.core.CoreContainer - 
> java.lang.NoClassDefFoundError: org/apache/velocity/context/Context
>       at org.apache.solr.core.SolrCore.<clinit>(SolrCore.java:1447)
>       at org.apache.solr.core.CoreContainer.create(CoreContainer.java:463)
>       at org.apache.solr.core.CoreContainer.load(CoreContainer.java:316)
>       at org.apache.solr.core.CoreContainer.load(CoreContainer.java:207)
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to