[ 
https://issues.apache.org/jira/browse/SOLR-2588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13067033#comment-13067033
 ] 

David Smiley commented on SOLR-2588:
------------------------------------

Hoss, you apparently have a black or white view of things -- something is 
needed or not without conditions.  I don't advocate removing Velocity from 
Solr's maven pom or the WAR file that comes with Solr.  However I do think that 
if the Solr user/packager realized that Velocity is not used in their setup 
(perhaps using Solr in an embedded fashion) and if Solr can gracefully work 
without it for the rest of Solr that doesn't need it, then it should run 
without it. There are many parts of Solr that are very loosely tied into the 
framework (a good thing) like request handlers, query parsers, response 
writers, text analysis etc.  Unless one of these are explicitly registered, I 
think Solr should not fail to start if a dependency isn't present.

bq. it's just not there w/o any warning/error on startup
This is a false claim. My patch logs a warning.

> Make Velocity an optional dependency in SolrCore
> ------------------------------------------------
>
>                 Key: SOLR-2588
>                 URL: https://issues.apache.org/jira/browse/SOLR-2588
>             Project: Solr
>          Issue Type: Wish
>    Affects Versions: 3.2
>            Reporter: Gunnar Wagenknecht
>            Assignee: David Smiley
>            Priority: Minor
>             Fix For: 3.4, 4.0
>
>         Attachments: SOLR-2588_Don_t_fail_if_velocity_libs_not_present_.patch
>
>
> In 1.4. it was fine to run Solr without Velocity on the classpath. However, 
> in 3.2. SolrCore won't load because of a hard reference to the Velocity 
> response writer in a static initializer.
> {noformat}
> ... ERROR org.apache.solr.core.CoreContainer - 
> java.lang.NoClassDefFoundError: org/apache/velocity/context/Context
>       at org.apache.solr.core.SolrCore.<clinit>(SolrCore.java:1447)
>       at org.apache.solr.core.CoreContainer.create(CoreContainer.java:463)
>       at org.apache.solr.core.CoreContainer.load(CoreContainer.java:316)
>       at org.apache.solr.core.CoreContainer.load(CoreContainer.java:207)
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to