[
https://issues.apache.org/jira/browse/LUCENE-8424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554222#comment-16554222
]
Tapan Vaishnav commented on LUCENE-8424:
----------------------------------------
Hi [~romseygeek],
Thanks for your quick response.
{quote}We can't just return immediately when the payload is null, due to
LUCENE-7744.
{quote}
I see, thanks for pointing it out. I will change accordingly.
{quote}It would also be good to add a test to TestPayloadScoreQuery that checks
behaviour when some and/or all payloads are null.{quote}
I tried doing so in TestPayloadScoreQuery but couldn't quite figure out where
to look for, I will try again to add some test cases.
> Payload null value exception handling
> -------------------------------------
>
> Key: LUCENE-8424
> URL: https://issues.apache.org/jira/browse/LUCENE-8424
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: 7.2, 7.3.1
> Reporter: Tapan Vaishnav
> Assignee: Alan Woodward
> Priority: Minor
> Attachments: LUCENE-8424.patch
>
>
> If-Condition to check payload null value in _PayloadScoreQuery.java_ was
> removed in LUCENE-8038. Because of that, regarding of the payload value,
> _payloadsSeen_ is always getting increment. This has compromised the overall
> score of the document(for instance, as payloadSeens is always greater than 0,
> docScore() in _MinPayloadFunction.java_ only returns payloadScore which can
> be zero depending on the payload value). Ideally, it should've returned 1 in
> case of _payload==null_.
> I have added a simple patch to get started, Please let me know if it needs
> any improvements.
> Thanks in advance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
