[
https://issues.apache.org/jira/browse/LUCENE-8424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16587630#comment-16587630
]
Alan Woodward commented on LUCENE-8424:
---------------------------------------
Hey [~tvaishna], apologies for the delay in responding, I've been away on
holiday for the past few weeks.
Having mulled this over while I've been away, I think we may be going about
this the wrong way. Rather than deciding in the parent query what to do with
null payloads, instead we should allow consumers to decide this directly. I'll
upload an example patch soonish which should explain what I mean.
> Payload null value exception handling
> -------------------------------------
>
> Key: LUCENE-8424
> URL: https://issues.apache.org/jira/browse/LUCENE-8424
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: 7.2, 7.3.1
> Reporter: Tapan Vaishnav
> Assignee: Alan Woodward
> Priority: Minor
> Attachments: LUCENE-8424.patch, LUCENE-8424.patch, LUCENE-8424.patch,
> LUCENE-8424.patch, LUCENE-8424.patch, LUCENE-8424.patch, LUCENE-8424.patch
>
>
> If-Condition to check payload null value in _PayloadScoreQuery.java_ was
> removed in LUCENE-8038. Because of that, regarding of the payload value,
> _payloadsSeen_ is always getting increment. This has compromised the overall
> score of the document(for instance, as payloadSeens is always greater than 0,
> docScore() in _MinPayloadFunction.java_ only returns payloadScore which can
> be zero depending on the payload value). Ideally, it should've returned 1 in
> case of _payload==null_.
> I have added a simple patch to get started, Please let me know if it needs
> any improvements.
> Thanks in advance.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
