[
https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564306#comment-16564306
]
Adrien Grand commented on LUCENE-8204:
--------------------------------------
+1 on the approach, thanks for the explanation about why we need to care about
requiring the opt clause on the whole block. It would be nice to only wrap the
approximation when scoreMode == TOP_SCORES?
Tests could use CheckHits#checkTopScores which does a bit more testing than
just checking whether top hits are ok. It'd also be nice to have one explicit
test for the case that the scorer keeps advancing block by block all the time,
and another one for the case that it considers the whole segment to decide that
the opt clause is required.
> ReqOptSumScorer should leverage sub scorers' per-block max scores
> -----------------------------------------------------------------
>
> Key: LUCENE-8204
> URL: https://issues.apache.org/jira/browse/LUCENE-8204
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-8204.patch, LUCENE-8204.patch
>
>
> Currently it only looks at max scores on the entire segment. Given that
> per-block max scores usually give lower upper bounds of the score, this
> should help.
> This is especially important for LUCENE-8197 to work well since the main
> query would typically be added as a MUST clauses of a boolean query while the
> query that scores on features would be a SHOULD clause.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
