[
https://issues.apache.org/jira/browse/LUCENE-8204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572971#comment-16572971
]
Adrien Grand commented on LUCENE-8204:
--------------------------------------
+1 in general, some minor comments below:
{code}
@Override
public int advance(int target) throws IOException {
return advanceInternal(reqApproximation.advance(target));
}
{code}
Should we call {{advanceImpacts}} on target before calling
{{reqApproximation.advance()}} on it? This would save decoding postings if
{{target}} is in a block that doesn't contain competitive matches? Same for
nextDoc()?
{code}
// Potentially move to a conjunction
if (reqMaxScoreBlock < minScore) {
optIsRequired = true;
} else {
optIsRequired = false;
}
{code}
Let's just do {{optIsRequired = reqMaxScoreBlock < minScore}}?
> ReqOptSumScorer should leverage sub scorers' per-block max scores
> -----------------------------------------------------------------
>
> Key: LUCENE-8204
> URL: https://issues.apache.org/jira/browse/LUCENE-8204
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-8204.patch, LUCENE-8204.patch, LUCENE-8204.patch,
> LUCENE-8204.patch
>
>
> Currently it only looks at max scores on the entire segment. Given that
> per-block max scores usually give lower upper bounds of the score, this
> should help.
> This is especially important for LUCENE-8197 to work well since the main
> query would typically be added as a MUST clauses of a boolean query while the
> query that scores on features would be a SHOULD clause.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
